yihua commented on code in PR #10467:
URL: https://github.com/apache/hudi/pull/10467#discussion_r1447690703
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -457,7 +457,7 @@ public Pair<Option<String>, JavaRDD<WriteStatus>>
syncOnce() throws IOException
private Option<String>
getLastPendingClusteringInstant(Option<HoodieTimeline> commitTimelineOpt) {
if (commitTimelineOpt.isPresent()) {
- Option<HoodieInstant> pendingClusteringInstant =
commitTimelineOpt.get().filterPendingReplaceTimeline().lastInstant();
+ Option<HoodieInstant> pendingClusteringInstant =
commitTimelineOpt.get().getLastPendingClusterCommit();
Review Comment:
Adding new instant types to differentiate clustering vs non-clustering
replacecommits would make it more performant, but it also incurs format changes
on storage. For now, let's fix the correctness first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
