yihua commented on code in PR #10330:
URL: https://github.com/apache/hudi/pull/10330#discussion_r1469116286
##########
hudi-common/src/main/java/org/apache/hudi/common/bloom/HoodieDynamicBoundedBloomFilter.java:
##########
@@ -64,14 +66,17 @@ public class HoodieDynamicBoundedBloomFilter implements
BloomFilter {
public HoodieDynamicBoundedBloomFilter(String serString) {
// ignoring the type code for now, since we have just one version
byte[] bytes = Base64CodecUtil.decode(serString);
- DataInputStream dis = new DataInputStream(new ByteArrayInputStream(bytes));
- try {
- internalDynamicBloomFilter = new InternalDynamicBloomFilter();
- internalDynamicBloomFilter.readFields(dis);
- dis.close();
- } catch (IOException e) {
- throw new HoodieIndexException("Could not deserialize BloomFilter
instance", e);
- }
+ extractAndSetInternalBloomFilter(new DataInputStream(new
ByteArrayInputStream(bytes)));
Review Comment:
The stream is closed inside the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
