yihua commented on code in PR #10330:
URL: https://github.com/apache/hudi/pull/10330#discussion_r1469124685
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReader.java:
##########
@@ -728,42 +464,100 @@ public IndexedRecord next() {
@Override
public void close() {
try {
- scanner.close();
reader.close();
} catch (IOException e) {
- throw new HoodieIOException("Error closing the hfile reader and
scanner", e);
+ throw new HoodieIOException("Error closing the HFile reader and
scanner", e);
}
}
- }
- static class SeekableByteArrayInputStream extends
ByteBufferBackedInputStream implements Seekable, PositionedReadable {
- public SeekableByteArrayInputStream(byte[] buf) {
- super(buf);
- }
+ private static Iterator<IndexedRecord>
getRecordByKeyPrefixIteratorInternal(HFileReader reader,
Review Comment:
Eventually, we will remove `HoodieAvroHBaseHFileReader` and the logic is
slightly different between the two. So, I choose to save time by not doing
abstraction here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
