danny0405 commented on code in PR #10588:
URL: https://github.com/apache/hudi/pull/10588#discussion_r1470587289
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -153,7 +158,11 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState,
metaClient.getTableConfig,
file.start,
file.length,
- shouldUseRecordPosition)
+ shouldUseRecordPosition,
+
options.getOrElse(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.key(),
HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.defaultValue() + "").toLong,
Review Comment:
@linliu-code @jonvex Can you help confirm whether this options include all
the write options?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -153,7 +158,11 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tableState: HoodieTableState,
metaClient.getTableConfig,
file.start,
file.length,
- shouldUseRecordPosition)
+ shouldUseRecordPosition,
+
options.getOrElse(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.key(),
HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.defaultValue() + "").toLong,
Review Comment:
@linliu-code @jonvex Can you help confirm whether this options include all
the write config options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
