danny0405 commented on code in PR #10588:
URL: https://github.com/apache/hudi/pull/10588#discussion_r1473654923
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -107,7 +108,11 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
HoodieTableConfig tableConfig,
long start,
long length,
- boolean shouldUseRecordPosition) {
+ boolean shouldUseRecordPosition,
+ long maxMemorySizeInBytes,
+ String spillableMapBasePath,
Review Comment:
yeah, there are two many parameters, we should add a builder for it just
like what we do to `AbstractHoodieLogRecordReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
