sreeram26 commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464568735
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -306,16 +317,106 @@ public boolean isInlineCompactionEnabled() {
return !continuousMode && !forceDisableCompaction
&&
HoodieTableType.MERGE_ON_READ.equals(HoodieTableType.valueOf(tableType));
}
+
Review comment:
Yes I wanted to add equals() for better testability and hence added
hashcode() as both go hand-in-hand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]