zhedoubushishi commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464660634
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws
ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
How about make this class public and move it to a more general package
e.g. ```hudi-common```?
There are some other classes which might also need this ```VoidSplitter```,
e.g.
https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java#L280,
https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java#L92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
