danny0405 commented on code in PR #10641:
URL: https://github.com/apache/hudi/pull/10641#discussion_r1485703297
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -324,7 +324,7 @@ private boolean metadataTableExists(HoodieTableMetaClient
dataMetaClient) throws
}
if (reInitialize) {
- metrics.ifPresent(m ->
m.updateMetrics(HoodieMetadataMetrics.REBOOTSTRAP_STR, 1));
+ metrics.ifPresent(m ->
m.incrementMetric(HoodieMetadataMetrics.REBOOTSTRAP_STR, 1));
LOG.info("Deleting Metadata Table directory so that it can be
re-initialized");
Review Comment:
Are we reporting multiple times for bootstrapping?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -147,6 +148,10 @@ public static HoodieWriteConfig createMetadataWriteConfig(
final Properties properties = new Properties();
properties.put(HoodieTableConfig.RECORDKEY_FIELDS.key(),
RECORD_KEY_FIELD_NAME);
properties.put("hoodie.datasource.write.recordkey.field",
RECORD_KEY_FIELD_NAME);
+ if (nonEmpty(writeConfig.getMetricReporterMetricsNamePrefix())) {
+ properties.put(HoodieMetricsConfig.METRICS_REPORTER_PREFIX.key(),
+ writeConfig.getMetricReporterMetricsNamePrefix() + "_metadata");
+ }
Review Comment:
Where does the `_metadata` constant string come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
