lokeshj1703 commented on code in PR #10641:
URL: https://github.com/apache/hudi/pull/10641#discussion_r1485824879
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -324,7 +324,7 @@ private boolean metadataTableExists(HoodieTableMetaClient
dataMetaClient) throws
}
if (reInitialize) {
- metrics.ifPresent(m ->
m.updateMetrics(HoodieMetadataMetrics.REBOOTSTRAP_STR, 1));
+ metrics.ifPresent(m ->
m.incrementMetric(HoodieMetadataMetrics.REBOOTSTRAP_STR, 1));
LOG.info("Deleting Metadata Table directory so that it can be
re-initialized");
Review Comment:
This metric is for rebootstrapping. `updateMetrics` is updating two metrics
- number of times rebootstrap is called and amount of time the action took.
There is no good way to calculate the time so I simplified the metric to track
only the number of times rebootstrap is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
