yihua commented on code in PR #10677: URL: https://github.com/apache/hudi/pull/10677#discussion_r1501729435
########## hudi-common/src/main/java/org/apache/hudi/exception/SchemaUnbalancedUnionException.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.exception; + +/** + * Thrown when a field is a union and at least one of the following is true: + * <ul> + * <li>the incoming union and the latest table union have differing numbers of types</li> + * <li>the incoming union has more than two types</li> + * </ul> + */ +public class SchemaUnbalancedUnionException extends SchemaCompatibilityException { Review Comment: rename to `InvalidUnionTypeException`? ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java: ########## @@ -859,8 +860,10 @@ private void validateSchema() throws HoodieUpsertException, HoodieInsertExceptio Schema writerSchema = HoodieAvroUtils.createHoodieWriteSchema(config.getSchema()); Schema tableSchema = HoodieAvroUtils.createHoodieWriteSchema(existingTableSchema.get()); AvroSchemaUtils.checkSchemaCompatible(tableSchema, writerSchema, shouldValidate, allowProjection, getDropPartitionColNames()); + } catch (SchemaCompatibilityException e) { + throw e; } catch (Exception e) { - throw new HoodieException("Failed to read schema/check compatibility for base path " + metaClient.getBasePath(), e); + throw new SchemaCompatibilityException("Failed to read schema/check compatibility for base path " + metaClient.getBasePath(), e); Review Comment: It looks like all such exception changes only make the exception thrown more specific, i.e., subclass of previous thrown exception (`SchemaCompatibilityException` class is a child of `HoodieException` class). Make sure that's case, and if not, we need to add docs to explicitly explain the outliers, since users catching the previous exception type may miss the new one. ########## hudi-common/src/main/java/org/apache/hudi/exception/MissingSchemaFieldException.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.exception; + +import java.util.List; + +/** + * Thrown when the schema of the incoming data is missing fields that are in the table schema. + */ +public class MissingSchemaFieldException extends SchemaCompatibilityException { Review Comment: How are `HoodieIncompatibleSchemaException`, `IncompatibleSchemaException`, and `UnsupportedAvroTypeException` now relate to `SchemaCompatibilityException`? Should they be consolidated too? ########## hudi-common/src/main/java/org/apache/hudi/exception/SchemaBackwardsCompatibilityException.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.exception; + +import org.apache.hudi.avro.AvroSchemaCompatibility; + +import java.util.stream.Collectors; + +/** + * Thrown when there is a backwards compatibility issue with the incoming schema. + * i.e. when the incoming schema cannot be used to read older data files + */ +public class SchemaBackwardsCompatibilityException extends SchemaCompatibilityException { Review Comment: Seems no need to create a new one, or is this specific for Avro (renamed to `AvroIncompatibleSchemaException`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
