jonvex commented on code in PR #10677: URL: https://github.com/apache/hudi/pull/10677#discussion_r1507945560
########## hudi-common/src/main/java/org/apache/hudi/exception/SchemaBackwardsCompatibilityException.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.exception; + +import org.apache.hudi.avro.AvroSchemaCompatibility; + +import java.util.stream.Collectors; + +/** + * Thrown when there is a backwards compatibility issue with the incoming schema. + * i.e. when the incoming schema cannot be used to read older data files + */ +public class SchemaBackwardsCompatibilityException extends SchemaCompatibilityException { + + public SchemaBackwardsCompatibilityException(AvroSchemaCompatibility.SchemaPairCompatibility compatibility) { + super(constructExceptionMessage(compatibility)); + } + + private static String constructExceptionMessage(AvroSchemaCompatibility.SchemaPairCompatibility compatibility) { + return "Schema validation backwards compatibility check failed with the following issues: {" + + compatibility.getResult().getIncompatibilities().stream() + .map(incompatibility -> incompatibility.getType().name() + ": " + incompatibility.getMessage()) Review Comment: Yes, If you look in AvroSchemaCompatibility.java you can see that the only time incompatible result is constructed in SchemaCompatibilityResult.incompatible. And all cals to that pass in the incompatibility type directly, not with a variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
