stayrascal commented on code in PR #10797:
URL: https://github.com/apache/hudi/pull/10797#discussion_r1509999420
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -66,17 +65,19 @@ public class FileSystemViewManager {
private final SerializableConfiguration conf;
// The View Storage config used to store file-system views
private final FileSystemViewStorageConfig viewStorageConfig;
- // Map from Base-Path to View
- private final ConcurrentHashMap<String, SyncableFileSystemView>
globalViewMap;
// Factory Map to create file-system views
private final Function2<HoodieTableMetaClient, FileSystemViewStorageConfig,
SyncableFileSystemView> viewCreator;
+ // Map from Base-Path to View
+ private final ConcurrentHashMap<String, SyncableFileSystemView>
globalViewMap;
Review Comment:
it's easy to compare & read if keep the sequence with constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
