stayrascal commented on code in PR #10797:
URL: https://github.com/apache/hudi/pull/10797#discussion_r1509999904
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -130,69 +131,69 @@ public void close() {
/**
* Create RocksDB based file System view for a table.
*
- * @param viewConf View Storage Configuration
+ * @param viewConf View Storage Configuration
* @param metaClient HoodieTableMetaClient
- * @return
+ * @return {@link RocksDbBasedFileSystemView}
*/
private static RocksDbBasedFileSystemView
createRocksDBBasedFileSystemView(FileSystemViewStorageConfig viewConf,
- HoodieTableMetaClient metaClient) {
+
HoodieTableMetaClient metaClient) {
HoodieTimeline timeline =
metaClient.getActiveTimeline().filterCompletedAndCompactionInstants();
return new RocksDbBasedFileSystemView(metaClient, timeline, viewConf);
}
/**
* Create a spillable Map based file System view for a table.
*
- * @param viewConf View Storage Configuration
+ * @param viewConf View Storage Configuration
* @param metaClient HoodieTableMetaClient
- * @return
+ * @return {@link SpillableMapBasedFileSystemView}
*/
- private static SpillableMapBasedFileSystemView
createSpillableMapBasedFileSystemView(FileSystemViewStorageConfig viewConf,
Review Comment:
`FileSystemViewStorageConfig viewConf` is never used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
