geserdugarov commented on code in PR #10851:
URL: https://github.com/apache/hudi/pull/10851#discussion_r1528087176


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -725,40 +725,45 @@ private FlinkOptions() {
       .withDescription("Target IO in MB for per compaction (both read and 
write), default 500 GB");
 
   public static final ConfigOption<Boolean> CLEAN_ASYNC_ENABLED = ConfigOptions
-      .key("clean.async.enabled")
+      .key("hoodie.cleaner.async.enabled")

Review Comment:
   There are some parameters without shortcuts in `FlinkOptions`:
   ```
   hoodie.bucket.index.hash.field
   hoodie.bucket.index.num.buckets
   hoodie.database.name
   hoodie.datasource.merge.type
   hoodie.datasource.query.type
   hoodie.datasource.write.hive_style_partitioning
   hoodie.datasource.write.keygenerator.class
   hoodie.datasource.write.keygenerator.type
   hoodie.datasource.write.partitionpath.field
   hoodie.datasource.write.partitionpath.urlencode
   hoodie.datasource.write.recordkey.field
   hoodie.index.bucket.engine
   hoodie.table.name
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to