geserdugarov commented on code in PR #10851:
URL: https://github.com/apache/hudi/pull/10851#discussion_r1528084191
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -725,40 +725,45 @@ private FlinkOptions() {
.withDescription("Target IO in MB for per compaction (both read and
write), default 500 GB");
public static final ConfigOption<Boolean> CLEAN_ASYNC_ENABLED = ConfigOptions
- .key("clean.async.enabled")
+ .key("hoodie.cleaner.async.enabled")
Review Comment:
@danny0405 , if it doesn't bother you, could you, please, clarify, why Flink
options are different from the similar Hudi kernel options? From user point of
view, it's unnecessary complication, you need to look for Flink variation of
naming even if you know some Spark or Hudi internal naming version for the same
option.
Could we create some naming convention for options? It's a nightmare, as I
mentioned in [HUDI-5738](https://issues.apache.org/jira/browse/HUDI-5738), we
have 900+ options for now. Could you, please, take a look at the attached file
in [HUDI-5738](https://issues.apache.org/jira/browse/HUDI-5738)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
