rmahindra123 commented on code in PR #10876:
URL: https://github.com/apache/hudi/pull/10876#discussion_r1529460065
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java:
##########
@@ -90,8 +94,11 @@ public class UpsertPartitioner<T> extends
SparkHoodiePartitioner<T> {
public UpsertPartitioner(WorkloadProfile profile, HoodieEngineContext
context, HoodieTable table,
Review Comment:
Should we add the implementation to a new class, may be
sortedUpsertPartitioner or something, so there is a clean separation. We can
use the same config to control which one gets called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]