bhat-vinay commented on code in PR #10876:
URL: https://github.com/apache/hudi/pull/10876#discussion_r1535695254
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -480,6 +480,20 @@ public class HoodieWriteConfig extends HoodieConfig {
.markAdvanced()
.withDocumentation(BulkInsertSortMode.class);
+ public static final ConfigProperty<Boolean> INSERT_SORT = ConfigProperty
+ .key("hoodie.insert.sort")
+ .defaultValue(false)
+ .markAdvanced()
+ .withDocumentation("Determines whether the insert operation should sort
the input records. The sorting for insert is always"
+ + " global (among all input records in a batch)");
+
+ public static final ConfigProperty<String> INSERT_USER_DEFINED_SORT_COLUMNS
= ConfigProperty
+ .key("hoodie.insert.user.defined.sort.columns")
+ .noDefaultValue()
+ .markAdvanced()
+ .withDocumentation("Columns to sort the data by when hoodie.insert.sort
is set to true. If not specified, record-key is used for sorting."
Review Comment:
Yes, it is. It was just not explicitly mentioned here. Update the document
to be more explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
