danny0405 commented on code in PR #10874:
URL: https://github.com/apache/hudi/pull/10874#discussion_r1536489142


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1130,22 +1128,6 @@ public void update(HoodieRollbackMetadata 
rollbackMetadata, String instantTime)
     }
   }
 
-  protected void validateRollback(
-      String commitToRollbackInstantTime,
-      HoodieInstant compactionInstant,

Review Comment:
   The rollback check needs to be kept because metadata such as RLI relies on 
the rollback of MDT commit, we can not do that if that commit has been 
compacted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to