danny0405 commented on code in PR #10874:
URL: https://github.com/apache/hudi/pull/10874#discussion_r1537186688
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1134,8 +1126,9 @@ protected void validateRollback(
String commitToRollbackInstantTime,
HoodieInstant compactionInstant,
HoodieTimeline deltacommitsSinceCompaction) {
- // The commit being rolled back should not be earlier than the latest
compaction on the MDT. Compaction on MDT only occurs when all actions
- // are completed on the dataset. Hence, this case implies a rollback of
completed commit which should actually be handled using restore.
+ // The commit being rolled back should not be earlier than the latest
compaction on the MDT because the latest file slice does not change after all.
+ // Compaction on MDT only occurs when all actions are completed on the
dataset.
Review Comment:
That was the first change of this PR, but there is a case for RLI rollback
now, the RLI does not include the index mappings in the commit metadata
file(instead it is committed along with it), the only way to rollback the RLI
mapping is to trigger the `#rollback` action on the `MDT` itself, that is why
this restriction is kept.
We can remove it if we can persist the RLI metadata somewhere and figure out
the tombstone msgs on the fly while do rollback, but that storage might be
costly, I have no clear solution yet, so just keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
