the-other-tim-brown commented on code in PR #10960:
URL: https://github.com/apache/hudi/pull/10960#discussion_r1552681983
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -197,6 +200,27 @@ public HoodieMetadataTableValidator(JavaSparkContext jsc,
Config cfg) {
this.taskLabels = generateValidationTaskLabels();
}
+ /**
+ * Returns list of Throwable which were encountered during validation. This
method is useful
+ * when ignoreFailed parameter is set to true.
Review Comment:
You may also want to note you can use this option to find all issues instead
of just the first one
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -197,6 +200,27 @@ public HoodieMetadataTableValidator(JavaSparkContext jsc,
Config cfg) {
this.taskLabels = generateValidationTaskLabels();
}
+ /**
+ * Returns list of Throwable which were encountered during validation. This
method is useful
+ * when ignoreFailed parameter is set to true.
+ */
+ public List<Throwable> getThrowables() {
+ return throwables;
+ }
+
+ /**
+ * Returns true if validation has failed. This method is useful when
ignoreFailed
+ * parameter is set to true.
+ */
+ public boolean isValidationFailed() {
Review Comment:
Nitpick: method name could be `hasValidationFailure()` to distinguish
between generic failures and validation failures?
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -180,6 +181,8 @@ public class HoodieMetadataTableValidator implements
Serializable {
private final String taskLabels;
+ private List<Throwable> throwables = new LinkedList<>();
Review Comment:
Nitpick: Any reason to use linked list over array list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
