lokeshj1703 commented on code in PR #10960:
URL: https://github.com/apache/hudi/pull/10960#discussion_r1552995109
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -180,6 +181,8 @@ public class HoodieMetadataTableValidator implements
Serializable {
private final String taskLabels;
+ private List<Throwable> throwables = new LinkedList<>();
Review Comment:
Addressed. No particular preference in this case. Generally I tend to use
linked list if the size of list is not known and I don't need random access.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -197,6 +200,27 @@ public HoodieMetadataTableValidator(JavaSparkContext jsc,
Config cfg) {
this.taskLabels = generateValidationTaskLabels();
}
+ /**
+ * Returns list of Throwable which were encountered during validation. This
method is useful
+ * when ignoreFailed parameter is set to true.
+ */
+ public List<Throwable> getThrowables() {
+ return throwables;
+ }
+
+ /**
+ * Returns true if validation has failed. This method is useful when
ignoreFailed
+ * parameter is set to true.
+ */
+ public boolean isValidationFailed() {
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
