vinothchandar commented on a change in pull request #1858:
URL: https://github.com/apache/hudi/pull/1858#discussion_r467608824
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -96,6 +97,8 @@ public HoodieTableConfig(FileSystem fs, String metaPath,
String payloadClassName
throw new HoodieIOException("Could not load Hoodie properties from " +
propertyPath, e);
}
this.props = props;
+
ValidationUtils.checkArgument(props.containsKey(HOODIE_TABLE_TYPE_PROP_NAME) &&
props.containsKey(HOODIE_TABLE_NAME_PROP_NAME),
Review comment:
these properties are written always. so this indicates a corrupted file
(with high probability) . Actually what we discussed is that there wont be a
corrupted/partial hoodie.properties file given even s3 (or gcs) guarantees
partial writes won't be visible. So this is just additional safety
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
