vinothchandar commented on a change in pull request #1858:
URL: https://github.com/apache/hudi/pull/1858#discussion_r467609575
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -96,6 +97,8 @@ public HoodieTableConfig(FileSystem fs, String metaPath,
String payloadClassName
throw new HoodieIOException("Could not load Hoodie properties from " +
propertyPath, e);
}
this.props = props;
+
ValidationUtils.checkArgument(props.containsKey(HOODIE_TABLE_TYPE_PROP_NAME) &&
props.containsKey(HOODIE_TABLE_NAME_PROP_NAME),
Review comment:
>sorry, I don't get why we need this here. If properties contain table
type and table name, why bail out?
we bail out if these props are not present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
