bvaradar commented on code in PR #10479:
URL: https://github.com/apache/hudi/pull/10479#discussion_r1556399888
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -516,13 +516,40 @@ public Option<HoodieInstant> getLastClusteringInstant() {
.findFirst());
}
+ @Override
+ public Option<HoodieInstant> getFirstPendingClusterInstant() {
+ return getLastOrFirstPendingClusterInstant(false);
+ }
+
@Override
public Option<HoodieInstant> getLastPendingClusterInstant() {
- return Option.fromJavaOptional(filterPendingReplaceTimeline()
- .getReverseOrderedInstants()
+ return getLastOrFirstPendingClusterInstant(true);
+ }
+
+ protected Option<HoodieInstant> getLastOrFirstPendingClusterInstant(boolean
getLast) {
Review Comment:
Make this private.
Rename getLast to isLast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
