bvaradar commented on code in PR #10479:
URL: https://github.com/apache/hudi/pull/10479#discussion_r1556399110
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/WriteMarkers.java:
##########
@@ -86,7 +86,7 @@ public Option<Path> create(String partitionPath, String
fileName, IOType type, H
HoodieTimeline pendingReplaceTimeline =
activeTimeline.filterPendingReplaceTimeline();
// TODO If current is compact or clustering then create marker directly
without early conflict detection.
// Need to support early conflict detection between table service and
common writers.
- if (pendingCompactionTimeline.containsInstant(instantTime) ||
pendingReplaceTimeline.containsInstant(instantTime)) {
Review Comment:
@jonvex : Wouldn't this cause extra compaction plan read at each writing
task level ? Instead, can you see if we can pass this information from the
driver ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
