beyond1920 commented on code in PR #10980:
URL: https://github.com/apache/hudi/pull/10980#discussion_r1556817370
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -147,6 +149,13 @@ public HoodieMergeHandle(HoodieWriteConfig config, String
instantTime, HoodieTab
this.preserveMetadata = true;
init(fileId, this.partitionPath, dataFileToBeMerged);
validateAndSetAndKeyGenProps(keyGeneratorOpt, config.populateMetaFields());
+ // if the old schema equals to the new schema, avoid heavy rewriting
+ if (config.populateMetaFields() && useWriterSchemaForCompaction) {
+ LOG.info("Using update instead rewriting during compaction");
+ copyOldFunc = (key, record, schema, prop) ->
this.updateMetadataToOldRecord(key, record, schema, prop);
Review Comment:
Good question.
The responsible of this method is only merging base record and incremental
record, not including handle schema evolution.
Handling schema evolution happens before call the `HoodieMergeHandle#write`
method.
<img width="1305" alt="image"
src="https://github.com/apache/hudi/assets/1525333/3a03e08b-fe2e-4da6-a788-07cbb6feeadd";>
<img width="1027" alt="image"
src="https://github.com/apache/hudi/assets/1525333/def1f2ee-ed97-47f8-92b6-76d45500bea7";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
