danny0405 commented on code in PR #10980:
URL: https://github.com/apache/hudi/pull/10980#discussion_r1557147035
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -147,6 +149,13 @@ public HoodieMergeHandle(HoodieWriteConfig config, String
instantTime, HoodieTab
this.preserveMetadata = true;
init(fileId, this.partitionPath, dataFileToBeMerged);
validateAndSetAndKeyGenProps(keyGeneratorOpt, config.populateMetaFields());
+ // The compactor avoids heavy rewriting when copy the old record from old
base file into new base file
+ if (config.populateMetaFields()) {
+ LOG.info("Using update instead of rewriting during compaction");
Review Comment:
`config.populateMetaFields()` is always true for data table(accounting to
the metadata table), if the schema evolution is handled correctly, I guess we
can always set up the metadata fields directly?
And please move the log level into "DEBUG".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
