xushiyan commented on a change in pull request #1871: URL: https://github.com/apache/hudi/pull/1871#discussion_r467662611
########## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FilesTestUtils.java ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.testutils; + +import org.apache.hudi.common.fs.FSUtils; +import org.apache.hudi.common.model.HoodieFileFormat; +import org.apache.hudi.common.model.IOType; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieTimeline; + +import java.io.File; +import java.io.IOException; +import java.io.RandomAccessFile; +import java.nio.file.Files; +import java.nio.file.Paths; + +public class FilesTestUtils { + + private static void fakeMetaFile(String basePath, String instantTime, String suffix) throws IOException { + String parentPath = basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME; + new File(parentPath).mkdirs(); + new File(parentPath + "/" + instantTime + suffix).createNewFile(); + } + + public static void fakeCommit(String basePath, String instantTime) throws IOException { Review comment: @yanghua how about `make`? since it is actually "making" stuff. e.g., legit marker files are indeed "made" by these APIs. Plus the follow-up work is to write actual data to these files, which make them real.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
