xushiyan commented on a change in pull request #1871:
URL: https://github.com/apache/hudi/pull/1871#discussion_r467669290
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -307,31 +299,26 @@ public static String createNewLogFile(FileSystem fs,
String basePath, String par
return fileID;
}
- public static void createCompactionCommitFiles(FileSystem fs, String
basePath, String... instantTimes)
- throws IOException {
- for (String instantTime : instantTimes) {
- boolean createFile = fs.createNewFile(new Path(basePath + "/" +
HoodieTableMetaClient.METAFOLDER_NAME + "/"
- + HoodieTimeline.makeCommitFileName(instantTime)));
- if (!createFile) {
- throw new IOException("cannot create commit file for commit " +
instantTime);
- }
- }
- }
-
public static void createCompactionRequest(HoodieTableMetaClient metaClient,
String instant,
- List<Pair<String, FileSlice>> fileSliceList) throws IOException {
+ List<Pair<String, FileSlice>>
fileSliceList) throws IOException {
Review comment:
I see the issue is that we did not set `forceStrictCondition` to `true`,
that's why intellij can align this and make the indentation longer than what
the rule sets.
https://checkstyle.sourceforge.io/config_misc.html#Indentation_Properties
@yanghua Do you agree we should set it to `true`? This can be done in a
separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
