nsivabalan commented on code in PR #11018:
URL: https://github.com/apache/hudi/pull/11018#discussion_r1568020073
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -129,6 +130,14 @@ public class HoodieStreamer implements Serializable {
public static final String STREAMSYNC_POOL_NAME = "hoodiedeltasync";
+ @VisibleForTesting
+ public HoodieStreamer(Config cfg, TypedProperties properties, Configuration
conf) throws IOException {
Review Comment:
my bad. lets not add constructor just for testing purpose.
may be you can make the other constructor call this and so source code will
exercise this code path.
and make the 2nd constructor VisibleForTesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
