sampan-s-nayak commented on code in PR #11018:
URL: https://github.com/apache/hudi/pull/11018#discussion_r1568189219
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -129,6 +130,14 @@ public class HoodieStreamer implements Serializable {
public static final String STREAMSYNC_POOL_NAME = "hoodiedeltasync";
+ @VisibleForTesting
+ public HoodieStreamer(Config cfg, TypedProperties properties, Configuration
conf) throws IOException {
Review Comment:
ah, I had intended to make this constructor package-private, made is public
by mistake. is it ok if we keep this package private? this way , this
constructor will only be used in tests and nowhere else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
