nsivabalan commented on a change in pull request #1834:
URL: https://github.com/apache/hudi/pull/1834#discussion_r468866921
##########
File path: hudi-client/src/main/java/org/apache/hudi/keygen/KeyGenerator.java
##########
@@ -51,4 +53,32 @@ protected KeyGenerator(TypedProperties config) {
throw new UnsupportedOperationException("Bootstrap not supported for key
generator. "
+ "Please override this method in your custom key generator.");
}
+
+ /**
+ * Initializes {@link KeyGenerator} for {@link Row} based operations.
+ * @param structType structype of the dataset.
+ * @param structName struct name of the dataset.
+ * @param recordNamespace record namespace of the dataset.
+ */
+ public void initializeRowKeyGenerator(StructType structType, String
structName, String recordNamespace) {
Review comment:
yes, we could do that. since HoodieDatasetBulkInsertHelper is the only
class calls into getRecordKey(row) and getPartitionPath(Row), it should have
access to structype and other args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
