nsivabalan commented on a change in pull request #1834: URL: https://github.com/apache/hudi/pull/1834#discussion_r468879180
########## File path: hudi-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java ########## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client.model; + +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.spark.sql.catalyst.InternalRow; +import org.apache.spark.sql.catalyst.util.ArrayData; +import org.apache.spark.sql.catalyst.util.MapData; +import org.apache.spark.sql.types.DataType; +import org.apache.spark.sql.types.Decimal; +import org.apache.spark.unsafe.types.CalendarInterval; +import org.apache.spark.unsafe.types.UTF8String; + +/** + * Internal Row implementation for Hoodie Row. It wraps an {@link InternalRow} and keeps meta columns locally. But the {@link InternalRow} + * does include the meta columns as well just that {@link HoodieInternalRow} will intercept queries for meta columns and serve from its + * copy rather than fetching from {@link InternalRow}. + */ +public class HoodieInternalRow extends InternalRow { + + private String commitTime; + private String commitSeqNumber; + private String recordKey; + private String partitionPath; + private String fileName; + private InternalRow row; + + public HoodieInternalRow(String commitTime, String commitSeqNumber, String recordKey, String partitionPath, + String fileName, InternalRow row) { + this.commitTime = commitTime; + this.commitSeqNumber = commitSeqNumber; + this.recordKey = recordKey; + this.partitionPath = partitionPath; + this.fileName = fileName; + this.row = row; + } + + @Override + public int numFields() { + return row.numFields(); + } + + @Override + public void setNullAt(int i) { + if (i < HoodieRecord.HOODIE_META_COLUMNS.size()) { + switch (i) { + case 0: { + this.commitTime = null; + break; + } + case 1: { + this.commitSeqNumber = null; + break; + } + case 2: { + this.recordKey = null; + break; + } + case 3: { + this.partitionPath = null; + break; + } + case 4: { + this.fileName = null; + break; + } + default: throw new IllegalArgumentException("Not expected"); + } + } else { + row.setNullAt(i); Review comment: even I had the same doubt when I start reviewing this at first. thats why added some java docs for this class. row will have meta columns as well. just that meta columns will not be fetched from the row but from instance variables in this class. @bvaradar did some analysis before arriving at this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
