nsivabalan commented on a change in pull request #1834:
URL: https://github.com/apache/hudi/pull/1834#discussion_r468884350
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/keygen/TimestampBasedKeyGenerator.java
##########
@@ -177,4 +191,26 @@ private long convertLongTimeToMillis(Long partitionVal) {
}
return MILLISECONDS.convert(partitionVal, timeUnit);
}
+
+ @Override
+ public String getRecordKey(Row row) {
+ return RowKeyGeneratorHelper.getRecordKeyFromRow(row,
getRecordKeyFields(), getRecordKeyPositions(), false);
+ }
+
+ @Override
+ public String getPartitionPath(Row row) {
+ Object fieldVal = null;
+ Object partitionPathFieldVal =
RowKeyGeneratorHelper.getNestedFieldVal(row,
getPartitionPathPositions().get(getPartitionPathFields().get(0)));
Review comment:
yes, this extends from SimpleKeyGenerator. Also, we have a special case
for partition path if incase we don't find the field. couldn't find a better
way to do it. position will return -1 and when parsing for actual Row, we will
return DEFAULT_PARTITION_PATH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
