danny0405 commented on code in PR #11096:
URL: https://github.com/apache/hudi/pull/11096#discussion_r1580257803
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HoodieHadoopStorage.java:
##########
@@ -202,8 +204,8 @@ public Object getFileSystem() {
}
@Override
- public Object getConf() {
- return fs.getConf();
+ public StorageConfiguration<Configuration> getConf() {
+ return new HadoopStorageConfiguration(fs.getConf());
}
Review Comment:
Can we add another short-cut method like `getHadoopConf` and make the return
type as Hadoop `Configuration` so we can eliminate those explicit type cast
from the callers. Or it's better if we can make the return type generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
