yihua commented on code in PR #11096:
URL: https://github.com/apache/hudi/pull/11096#discussion_r1580491690
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HoodieHadoopStorage.java:
##########
@@ -202,8 +204,8 @@ public Object getFileSystem() {
}
@Override
- public Object getConf() {
- return fs.getConf();
+ public StorageConfiguration<Configuration> getConf() {
+ return new HadoopStorageConfiguration(fs.getConf());
}
Review Comment:
The idea is that the `StorageConfiguration` object will be passed around
(see #11071). Right now there's still mixed usage of `FileSystem` vs
`HoodieStorage` so there needs to be adaptation code and class cast.
Eventually, there is no need to use `Configuration` thus I did not add
`getHadoopConf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
