yihua commented on code in PR #11071:
URL: https://github.com/apache/hudi/pull/11071#discussion_r1583607149
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -198,7 +198,7 @@ private void inlineCompaction(HoodieTable table,
Option<Map<String, String>> ext
* @return Collection of Write Status
*/
protected HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
- HoodieTable<?, I, ?, T> table = createTable(config,
context.getHadoopConf().get());
+ HoodieTable<?, I, ?, T> table = createTable(config, (Configuration)
context.getStorageConf().unwrap());
Review Comment:
New util methods are added in this one so they are clear: #11121
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -198,7 +198,7 @@ private void inlineCompaction(HoodieTable table,
Option<Map<String, String>> ext
* @return Collection of Write Status
*/
protected HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
- HoodieTable<?, I, ?, T> table = createTable(config,
context.getHadoopConf().get());
+ HoodieTable<?, I, ?, T> table = createTable(config, (Configuration)
context.getStorageConf().unwrap());
Review Comment:
New util methods are added in this PR so they are clear: #11121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
