yihua commented on code in PR #11071:
URL: https://github.com/apache/hudi/pull/11071#discussion_r1583398872
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java:
##########
@@ -67,8 +67,8 @@ public static StorageConfiguration<Configuration>
getStorageConf(Configuration c
return getStorageConf(conf, false);
}
- public static StorageConfiguration<Configuration>
getStorageConf(Configuration conf, boolean copy) {
- return new HadoopStorageConfiguration(conf, copy);
+ public static StorageConfiguration<Configuration>
getStorageConfWithCopy(Configuration conf) {
+ return getStorageConf(conf, true);
Review Comment:
Not really. The current logic is not changed, i.e., only copying the
underlying configuration when instantiating a new `HoodieTableMetaClient`. In
other places, if the Hadoop configuration is directly passed to create the
`FileSystem` or `HoodieStorage` instance, we do not copy the configuration.
Ideally, we should also avoid copying the configuration if not necessary; this
PR does the refactoring without changing the existing logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
