vinothchandar commented on a change in pull request #1963:
URL: https://github.com/apache/hudi/pull/1963#discussion_r470431566
##########
File path: hudi-client/src/main/java/org/apache/hudi/index/hbase/HBaseIndex.java
##########
@@ -182,6 +182,7 @@ private boolean checkIfValidCommit(HoodieTableMetaClient
metaClient, String comm
// 2) is less than the first commit ts in the timeline
return !commitTimeline.empty()
&& (commitTimeline.containsInstant(new HoodieInstant(false,
HoodieTimeline.COMMIT_ACTION, commitTs))
Review comment:
we could use the `metaClient.getCommitsTimeline()` or one of those
methods which will automatically determine the commit instant type based on
table type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
