rmpifer commented on a change in pull request #1963:
URL: https://github.com/apache/hudi/pull/1963#discussion_r473247387
##########
File path: hudi-client/src/main/java/org/apache/hudi/index/hbase/HBaseIndex.java
##########
@@ -177,13 +176,11 @@ private Get generateStatement(String key) throws
IOException {
}
private boolean checkIfValidCommit(HoodieTableMetaClient metaClient, String
commitTs) {
- HoodieTimeline commitTimeline =
metaClient.getActiveTimeline().filterCompletedInstants();
+ HoodieTimeline commitTimeline =
metaClient.getCommitsTimeline().filterCompletedInstants();
Review comment:
@n3nash It looks like HoodieTableMetaClient.getCommitsTimeline
internally calls getActiveTimeline()
https://github.com/rmpifer/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java#L478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
