codope commented on code in PR #11077: URL: https://github.com/apache/hudi/pull/11077#discussion_r1592165452
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java: ########## @@ -81,7 +83,7 @@ public class HoodieMergedLogRecordScanner extends AbstractHoodieLogRecordReader // A timer for calculating elapsed time in millis public final HoodieTimer timer = HoodieTimer.create(); // Map of compacted/merged records - private final ExternalSpillableMap<String, HoodieRecord> records; + private final ExternalSpillableMap<HoodieMergeKey, HoodieRecord> records; Review Comment: You're right, it does not overload anything. But, if we make it `Serializable`, then we need to make changes at the callers of `HoodieMergedLogRecordScanner.getRecords()` to decide how to change the `Serializable` to String key. A separate abstraction is cleaner as we don't leak any information at layers above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
