codope commented on PR #11077: URL: https://github.com/apache/hudi/pull/11077#issuecomment-2103013545
@danny0405 Based on our discussion, I have removed the `HoodieMergeKey` API and created a subclass `HoodieMetadataMergedLogRecordScanner` which works with `ExternalSpillableMap<Serializable, HoodieRecord>` (instead of string keys). It is used only for `HoodieMetadataLogRecordReader` and introduced a `HoodieMetadataRecordMerger`. The merger currently mimics the super class, but it will change for secondary index in subsequent PR. Please review this PR again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
