danny0405 commented on code in PR #11169:
URL: https://github.com/apache/hudi/pull/11169#discussion_r1593229207
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/DayBasedCompactionStrategy.java:
##########
@@ -60,6 +62,17 @@ public Comparator<String> getComparator() {
return comparator;
}
+ @Override
+ public List<HoodieCompactionOperation> orderAndFilter(HoodieWriteConfig
writeConfig,
Review Comment:
should we extend from `BoundedIOCompactionStrategy` and by default does not
limit the IO boundary(make it a maximum default value maybe)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
