Askwang commented on code in PR #11169:
URL: https://github.com/apache/hudi/pull/11169#discussion_r1593353079
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/DayBasedCompactionStrategy.java:
##########
@@ -60,6 +62,17 @@ public Comparator<String> getComparator() {
return comparator;
}
+ @Override
+ public List<HoodieCompactionOperation> orderAndFilter(HoodieWriteConfig
writeConfig,
Review Comment:
Maybe add a boolean value is more reasonable. `BoundedIOCompactionStrategy`
has a default config `hoodie.compaction.target.io` with value 512G. Following
your idea，we should add a similar new config like `hoodie.compaction.target.io`
which make it maximum default value. That seems a little conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
