jonvex commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1594581863
##########
hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java:
##########
@@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() {
private List<MetricsReporter>
addAdditionalMetricsExporters(HoodieMetricsConfig metricConfig) {
List<MetricsReporter> reporterList = new ArrayList<>();
List<String> propPathList =
StringUtils.split(metricConfig.getMetricReporterFileBasedConfigs(), ",");
- try (HoodieStorage storage = HoodieStorageUtils.getStorage(
- propPathList.get(0), HadoopFSUtils.getStorageConf(new
Configuration()))) {
+ try (HoodieStorage storage =
HoodieStorageUtils.getStorage(propPathList.get(0))) {
Review Comment:
don't make it use hoodiestorageutils becuase we don't want to expose an
option to not pass a config. Create followup ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
