jonvex commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1594408581
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/FileSystemTestUtils.java:
##########
@@ -79,34 +68,4 @@ public static void deleteFile(File fileToDelete) throws
IOException {
throw new IOException(message);
}
}
-
- public static List<FileStatus> listRecursive(FileSystem fs, Path path)
throws IOException {
- return listFiles(fs, path, true);
- }
-
- public static List<FileStatus> listFiles(FileSystem fs, Path path, boolean
recursive) throws IOException {
- RemoteIterator<LocatedFileStatus> itr = fs.listFiles(path, recursive);
- List<FileStatus> statuses = new ArrayList<>();
- while (itr.hasNext()) {
- statuses.add(itr.next());
- }
- return statuses;
- }
-
- public static List<StoragePathInfo> listRecursive(HoodieStorage storage,
StoragePath path)
- throws IOException {
- return listFiles(storage, path);
- }
-
- public static List<StoragePathInfo> listFiles(HoodieStorage storage,
StoragePath path)
- throws IOException {
- return storage.listFiles(path);
- }
-
- public static String readLastLineFromResourceFile(String resourceName)
throws IOException {
- try (InputStream inputStream =
TestLogReaderUtils.class.getResourceAsStream(resourceName)) {
- List<String> lines = FileIOUtils.readAsUTFStringLines(inputStream);
- return lines.get(lines.size() - 1);
- }
- }
Review Comment:
```
public static String readLastLineFromResourceFile(String resourceName)
throws IOException {
try (InputStream inputStream =
TestLogReaderUtils.class.getResourceAsStream(resourceName)) {
List<String> lines = FileIOUtils.readAsUTFStringLines(inputStream);
return lines.get(lines.size() - 1);
}
}
```
needed to be moved since it uses a class that's now in hudi-hadoop-common.
Since I was moving that one, I just moved all the rest of the hadoop ones as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
