yihua commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1595814771
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -674,14 +674,15 @@ private static HoodieLogBlock getBlock(HoodieWriteConfig
writeConfig,
List<HoodieRecord> records,
boolean shouldWriteRecordPositions,
Map<HeaderMetadataType, String>
header,
- String keyField) {
+ String keyField,
+ HoodieStorage storage) {
switch (logDataBlockFormat) {
case AVRO_DATA_BLOCK:
return new HoodieAvroDataBlock(records, shouldWriteRecordPositions,
header, keyField);
case HFILE_DATA_BLOCK:
return new HoodieHFileDataBlock(
records, header, writeConfig.getHFileCompressionAlgorithm(), new
StoragePath(writeConfig.getBasePath()),
-
writeConfig.getBooleanOrDefault(HoodieReaderConfig.USE_NATIVE_HFILE_READER));
+
writeConfig.getBooleanOrDefault(HoodieReaderConfig.USE_NATIVE_HFILE_READER),
storage);
Review Comment:
We can change the logic in an independent PR. It's usually good to avoid
such argument passing changes if not necessary, so there's less risk of
breaking the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
