yihua commented on code in PR #11131:
URL: https://github.com/apache/hudi/pull/11131#discussion_r1595827566
##########
hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java:
##########
@@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() {
private List<MetricsReporter>
addAdditionalMetricsExporters(HoodieMetricsConfig metricConfig) {
List<MetricsReporter> reporterList = new ArrayList<>();
List<String> propPathList =
StringUtils.split(metricConfig.getMetricReporterFileBasedConfigs(), ",");
- try (HoodieStorage storage = HoodieStorageUtils.getStorage(
- propPathList.get(0), HadoopFSUtils.getStorageConf(new
Configuration()))) {
+ try (HoodieStorage storage =
HoodieStorageUtils.getStorage(propPathList.get(0))) {
Review Comment:
The empty `new Configuration()` should not be used here. We should track
down the existing code since it may cause issues of accessing the files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
