codope commented on code in PR #11077:
URL: https://github.com/apache/hudi/pull/11077#discussion_r1602430560
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -222,7 +223,8 @@ public Iterator<HoodieRecord> iterator() {
}
public Map<String, HoodieRecord> getRecords() {
- return records;
+ return records.entrySet().stream().collect(
Review Comment:
No type cast is required, generic type is sufficient. So, this method should
always return string otherwise we have to change all the callers, including
merge handle, which we don't want to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
