codope commented on code in PR #11077:
URL: https://github.com/apache/hudi/pull/11077#discussion_r1603377704
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -222,7 +223,8 @@ public Iterator<HoodieRecord> iterator() {
}
public Map<String, HoodieRecord> getRecords() {
- return records;
+ return records.entrySet().stream().collect(
Review Comment:
Discussed offline, and we are aligned on the following approach (which is
also done as part of the last commit):
Introduce a new abstract class `BaseHoodieMergedLogRecordScanner` which
subclasses from `AbstractHoodieLogRecordReader`. The new abstract class holds
the `records` map as `ExternalSpillableMap<K, HoodieRecord>` and exposes
`public abstract Map<K, HoodieRecord> getRecords()` API. The existing
`HoodieMergedLogRecordScanner` now derives from the new abstract class (instead
of `AbstractHoodieLogRecordReader`) and uses String keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
